Add MList #52
Merged
Add MList #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is it only me? feeling uncomfortable to see the dark colored selected item text in dark mode? |
rookiejava
reviewed
Dec 3, 2019
| public class MList : GenList, IColorSchemeComponent | ||
| { | ||
| HashSet<GenItem> _realizedItems = new HashSet<GenItem>(); | ||
| Color _none = new Color(0, 0, 0, 0); |
Contributor
There was a problem hiding this comment.
What none means? What is different with default and Color.Black?
Contributor
Author
There was a problem hiding this comment.
It is different with Color.Black, I changed the name to _transparent
| } | ||
| } | ||
|
|
||
| protected void OnListDeleted(object sender, EventArgs e) |
| { | ||
| public class MList : GenList, IColorSchemeComponent | ||
| { | ||
| HashSet<GenItem> _realizedItems = new HashSet<GenItem>(); |
Contributor
There was a problem hiding this comment.
Do we need to hold additional item list?
Contributor
Author
There was a problem hiding this comment.
That's because GenList doesn't provide to access to GenItems they have internally.
GenItems are needed whenever the theme color is changed, MList saves the items when it is realized.
rookiejava
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is for adding MList
Issues Resolved
API Changes
Added
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
PR Checklist